twalthr commented on issue #7777: [FLINK-9964][table] Add a full RFC-compliant CSV table format factory URL: https://github.com/apache/flink/pull/7777#issuecomment-466478443 Thanks for the review @dawidwys. I addressed your comments. I think we don't need an end-to-end test for everything. Esp. with the serialization test we should be good now. If you think we should have those nevertheless. Feel free to open an follow-up issue. Will merge it now due to feature freeze. @flinkbot approve quality
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services