dawidwys commented on a change in pull request #7777: [FLINK-9964][table] Add
a full RFC-compliant CSV table format factory
URL: https://github.com/apache/flink/pull/7777#discussion_r259413826
##########
File path:
flink-formats/flink-csv/src/main/java/org/apache/flink/formats/csv/CsvRowSerializationSchema.java
##########
@@ -194,91 +199,121 @@ public int hashCode() {
//
--------------------------------------------------------------------------------------------
- private void convertRow(ObjectNode reuse, Row row, RowTypeInfo
rowTypeInfo) {
- final TypeInformation[] types = rowTypeInfo.getFieldTypes();
+ private interface RuntimeConverter extends Serializable {
+ JsonNode convert(CsvMapper csvMapper, ContainerNode<?>
container, Object obj);
+ }
+
+ private static RuntimeConverter createRowRuntimeConverter(RowTypeInfo
rowTypeInfo, boolean isTopLevel) {
Review comment:
Split similarly as in `Deserialization` schema
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
