sjwiesman commented on a change in pull request #7747: 
[FLINK-11653][DataStream] Add configuration to enforce custom UID's o…
URL: https://github.com/apache/flink/pull/7747#discussion_r259347921
 
 

 ##########
 File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
 ##########
 @@ -348,6 +348,13 @@ private StreamConfig createJobVertex(
                                        "Did you generate them before calling 
this method?");
                }
 
+               if 
(!streamGraph.getExecutionConfig().hasAutoGeneratedUIDsEnabled()) {
 
 Review comment:
   Unfortunately we can’t do that, flink only uses the uid for the first 
operator in each operator chain. Most users seem to understand that and only 
set UIDs in those places. This is the only place we can check that the opeator 
id assigned to each job vertex is from a manually set uid which is what we’re 
really after.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to