dawidwys commented on a change in pull request #7777: [FLINK-9964][table] Add a full RFC-compliant CSV table format factory URL: https://github.com/apache/flink/pull/7777#discussion_r258863672
########## File path: flink-formats/flink-csv/src/test/java/org/apache/flink/formats/csv/CsvRowDeSerializationSchemaTest.java ########## @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.formats.csv; + +import org.apache.flink.api.common.typeinfo.TypeInformation; +import org.apache.flink.api.common.typeinfo.Types; +import org.apache.flink.types.Row; + +import org.junit.Test; + +import java.io.IOException; +import java.math.BigDecimal; +import java.math.BigInteger; +import java.sql.Date; +import java.sql.Time; +import java.sql.Timestamp; +import java.util.function.Consumer; + +import static org.junit.Assert.assertArrayEquals; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertNull; +import static org.junit.Assert.fail; + +/** + * Tests for {@link CsvRowSerializationSchema} and {@link CsvRowDeserializationSchema}. + */ +public class CsvRowDeSerializationSchemaTest { + + @Test + @SuppressWarnings("unchecked") + public void testSerializeDeserialize() throws IOException { + + testNullableField(Types.LONG, "null", null); + testNullableField(Types.STRING, "null", null); + testNullableField(Types.VOID, "null", null); + testNullableField(Types.STRING, "\"This is a test.\"", "This is a test."); + testNullableField(Types.STRING, "\"This is a test\n\r.\"", "This is a test\n\r."); + testNullableField(Types.BOOLEAN, "true", true); + testNullableField(Types.BOOLEAN, "null", null); + testNullableField(Types.BYTE, "124", (byte) 124); + testNullableField(Types.SHORT, "10000", (short) 10000); + testNullableField(Types.INT, "1234567", 1234567); + testNullableField(Types.LONG, "12345678910", 12345678910L); + testNullableField(Types.FLOAT, "0.33333334", 0.33333334f); + testNullableField(Types.DOUBLE, "0.33333333332", 0.33333333332d); + testNullableField(Types.BIG_DEC, + "\"1234.0000000000000000000000001\"", + new BigDecimal("1234.0000000000000000000000001")); + testNullableField(Types.BIG_INT, + "\"123400000000000000000000000000\"", + new BigInteger("123400000000000000000000000000")); + testNullableField(Types.SQL_DATE, "2018-10-12", Date.valueOf("2018-10-12")); + testNullableField(Types.SQL_TIME, "12:12:12", Time.valueOf("12:12:12")); + testNullableField( + Types.SQL_TIMESTAMP, + "\"2018-10-12 12:12:12.0\"", + Timestamp.valueOf("2018-10-12 12:12:12")); + testNullableField( + Types.ROW(Types.STRING, Types.INT, Types.BOOLEAN), + "Hello;42;false", + Row.of("Hello", 42, false)); + testNullableField( + Types.OBJECT_ARRAY(Types.STRING), + "a;b;c", + new String[] {"a", "b", "c"}); + testNullableField( + Types.OBJECT_ARRAY(Types.BYTE), + "12;4;null", + new Byte[] {12, 4, null}); + testNullableField( + (TypeInformation<byte[]>) Types.PRIMITIVE_ARRAY(Types.BYTE), + "awML", + new byte[] {107, 3, 11}); + } + + @Test + public void testCustomizedProperties() throws IOException { + + final Consumer<CsvRowSerializationSchema> serConfig = (serSchema) -> { + serSchema.setEscapeCharacter('*'); + serSchema.setQuoteCharacter('\''); + serSchema.setArrayElementDelimiter(":"); + serSchema.setFieldDelimiter(';'); + }; + + final Consumer<CsvRowDeserializationSchema> deserConfig = (deserSchema) -> { + deserSchema.setEscapeCharacter('*'); + deserSchema.setQuoteCharacter('\''); + deserSchema.setArrayElementDelimiter(":"); + deserSchema.setFieldDelimiter(';'); + }; + + testField(Types.STRING, "123*'4**", "123'4*", deserConfig, ";"); + testField(Types.STRING, "'123''4**'", "123'4*", serConfig, deserConfig, ";"); + testField(Types.STRING, "'a;b*'c'", "a;b'c", deserConfig, ";"); + testField(Types.STRING, "'a;b''c'", "a;b'c", serConfig, deserConfig, ";"); + testField(Types.INT, " 12 ", 12, deserConfig, ";"); + testField(Types.INT, "12", 12, serConfig, deserConfig, ";"); + testField(Types.ROW(Types.STRING, Types.STRING), "1:hello", Row.of("1", "hello"), deserConfig, ";"); + testField(Types.ROW(Types.STRING, Types.STRING), "'1:hello'", Row.of("1", "hello"), serConfig, deserConfig, ";"); + testField(Types.ROW(Types.STRING, Types.STRING), "'1:hello world'", Row.of("1", "hello world"), serConfig, deserConfig, ";"); + testField(Types.STRING, "null", "null", serConfig, deserConfig, ";"); // string because null literal has not been set + } + + @Test + public void testDeserializationProperties() throws IOException { + final TypeInformation<Row> rowInfo = Types.ROW(Types.STRING, Types.INT, Types.STRING); + final CsvRowDeserializationSchema deserializationSchema = new CsvRowDeserializationSchema(rowInfo); + + try { + deserializationSchema.deserialize("Test,null,Test".getBytes()); // null not supported + fail("Missing field should cause failure."); + } catch (IOException e) { + // valid exception + } + + deserializationSchema.setIgnoreParseErrors(true); + + // unsupported null for integer + assertEquals(Row.of("Test", null, "Test"), deserializationSchema.deserialize("Test,null,Test".getBytes())); Review comment: nit: Could we have those as separate tests? Personally prefer this approach as it immediately shows what failed (by the test name). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
