zhijiangW opened a new pull request #7785: [FLINK-11707][network] Make InputGate extend AutoCloseable URL: https://github.com/apache/flink/pull/7785 ## What is the purpose of the change *This is a sub-task for refactoring the interface of `InputGate` which would be created by `ShuffleService` future. So it is reasonable to reference with general `InputGate` anywhere instead of specific `SingleInputGate`.* *To make `InputGate` extend `AutoCloseable` interface, the `TaskCanceler` could call `InputGate#close` instead of `SingleInputGate#releaseAllResources`.* *Next we can further remove the reference with `SingleInputGate` in Task class by refactoring the `updatePartitionInfo` into `NetworkEnvironment`.* ## Brief change log - *Make `InputGate` extend `AutoCloseable` interface* - *Change to reference with `InputGate` in `TaskCanceler`* - *Rename `releaseAllResources` into `close` in `ResultPartition`* ## Verifying this change This change is already covered by existing tests, such as *SingleInputGateTest*. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
