Myasuka commented on issue #7783: [FLINK-11699][JobManager] Use equals for String compare in AbstractDispatcherResourceManagerComponentFactory URL: https://github.com/apache/flink/pull/7783#issuecomment-465843723 Just feel curious about that had this ever caused a bug? The possible address of `""` in `AkkaRpcService` should just stay in the string pool of java heap, which means `rpcServiceAddress == ""` should be okay. But this code style is not recommend, better to fix this as this PR suggested.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
