tillrohrmann commented on a change in pull request #7745: [FLINK-11632] Add new
config option for TaskManager automatic address binding
URL: https://github.com/apache/flink/pull/7745#discussion_r258530486
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
##########
@@ -409,13 +409,30 @@ public static RpcService createRpcService(
if (taskManagerHostname != null) {
LOG.info("Using configured hostname/address for
TaskManager: {}.", taskManagerHostname);
} else {
- Time lookupTimeout =
Time.milliseconds(AkkaUtils.getLookupTimeout(configuration).toMillis());
-
- InetAddress taskManagerAddress =
LeaderRetrievalUtils.findConnectingAddress(
- haServices.getResourceManagerLeaderRetriever(),
- lookupTimeout);
-
- taskManagerHostname = taskManagerAddress.getHostName();
+ InetAddress taskManagerAddress;
Review comment:
I agree with Ufuk because we might break setups with this change. Either we
make configurable whether to take the `ip` or the `hostname` from the
heuristically determined `taskManagerAddress` or we make `auto-detect-hostname`
the default.
Additionally we should open a ticket to remove the heuristic/making the
default a non-heuristic approach. But before we actually do this, we should
discuss it and try to figure out what the consequences are.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
