StefanRRichter commented on a change in pull request #7662: [FLINK-10431]
Extraction of scheduling-related code from SlotPool into preliminary Scheduler
(rebased)
URL: https://github.com/apache/flink/pull/7662#discussion_r256878807
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/TestingComponentMainThreadExecutor.java
##########
@@ -77,9 +77,18 @@ public TestingComponentMainThreadExecutorServiceAdapter
getMainThreadExecutor()
*/
public static class Resource extends ExternalResource {
+ private long shutdownTimeoutMillis;
private TestingComponentMainThreadExecutor
componentMainThreadTestExecutor;
private ScheduledExecutorService innerExecutorService;
+ public Resource() {
+ this(500L);
Review comment:
Yes, I think 500ms are (more) than enough for what the test need.
Technically I think they could also run all run fine with 0L.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
