rmetzger commented on a change in pull request #7257: [FLINK-11089]Log 
filecache directory removed messages
URL: https://github.com/apache/flink/pull/7257#discussion_r256392083
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/filecache/FileCache.java
 ##########
 @@ -150,9 +150,10 @@ public void shutdown() {
                        for (File dir : storageDirectories) {
                                try {
                                        FileUtils.deleteDirectory(dir);
+                                       LOG.info("removed file cache directory 
{}", dir.getAbsolutePath());
                                }
                                catch (IOException e) {
-                                       LOG.error("File cache could not 
properly clean up storage directory.");
+                                       LOG.error("File cache could not 
properly clean up storage directory: " + dir, e);
 
 Review comment:
   ```suggestion
                                        LOG.error("File cache could not 
properly clean up storage directory: {}", dir, e);
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to