zentol commented on a change in pull request #7682:
[FLINK-11583][configuration] Support deprecated and fallback keys at once
URL: https://github.com/apache/flink/pull/7682#discussion_r256139016
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/ConfigOption.java
##########
@@ -134,10 +138,13 @@
* @return A new config options, with the given deprecated keys.
*/
public ConfigOption<T> withDeprecatedKeys(String... deprecatedKeys) {
- FallbackKey[] fallbackKeys = Arrays.stream(deprecatedKeys)
- .map(FallbackKey::createDeprecatedKey)
+ final Stream<FallbackKey> newFallbackKeys =
Arrays.stream(deprecatedKeys).map(FallbackKey::createFallbackKey);
Review comment:
I'll also check if I can't add a test to ensure that deprecated keys are
indeed considered deprecated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
