twalthr commented on a change in pull request #7664: [FLINK-11449][table] Uncouple the Expression class from RexNodes. URL: https://github.com/apache/flink/pull/7664#discussion_r255051899
########## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/expressions/FunctionDefinitions.java ########## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.expressions; + +import java.lang.reflect.Field; +import java.util.LinkedList; +import java.util.List; + +/** + * FunctionDefinitions is like a dictionary, defining all FunctionDefinitions as constants. + */ +public class FunctionDefinitions { + + public static final FunctionDefinition CAST = new FunctionDefinition("cast"); + public static final FunctionDefinition FLATTENING = new FunctionDefinition("flattening"); Review comment: We should name the methods as they are used in the API and documented. So "flatten" in this case. Or "get" for the next line here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
