stevenzwu commented on issue #7606: [FLINK-10774] Rework lifecycle management of partitionDiscoverer in FlinkKafkaConsumerBase URL: https://github.com/apache/flink/pull/7606#issuecomment-459455146 @tillrohrmann sorry for a late question. you mentioned `This implies that all users of this class need to call close() in order to properly clean up resources.` I also noticed your test cases explicitly calls `close` method to clean up resources. In production/distributed environment, when a job restart due to exception from `open` method, only `cancel` method was called. `close` method wasn't invoked in this case. that was my experience with 1.4. is that still true?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
