Myasuka commented on issue #7600: [FLINK-11368][tests] Port TaskManagerStartupTest to new code base URL: https://github.com/apache/flink/pull/7600#issuecomment-459390193 @zentol The logic of previous `testStartupWhenTaskmanagerActorPortIsUsed` test was a bit strange, because the `port` given to `#runTaskManager()` method was already be occupied by task-manager's server socket. If task-manager could not occupy that port, it would throw `BindException(s"Unable to allocate port for TaskManager.")` before calling `#runTaskManager()`. On the other hand, `TaskManagerRunner` verify port whether available through `#createRpcService`, which is before `#startTaskManager()`. And `BootstrapToolsTest#testActorSystemInstantiationFailureWhenPortOccupied()` should already cover this case.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
