tillrohrmann commented on a change in pull request #7613:
[FLINK-11370][test]Check and port ZooKeeperLeaderElectionITCase to ne…
URL: https://github.com/apache/flink/pull/7613#discussion_r252705212
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/LeaderChangeClusterComponentsTest.java
##########
@@ -141,6 +142,16 @@ public void testReelectionOfJobMaster() throws Exception {
assertThat(jobResult.isSuccess(), is(true));
}
+ @Test
+ public void testTaskManagerRegisterReelectionOfResourceManager() throws
Exception {
+
+ assertTrue(miniCluster.requestTaskManagerInfo().get().size() ==
NUM_TMS);
+
highAvailabilityServices.revokeResourceManagerLeadership().get();
+ highAvailabilityServices.grantResourceManagerLeadership().get();
+ Thread.sleep(500);
Review comment:
We should try to use sleeps. I would suggest to use a polling loop with a
lower sleep interval to make the test a bit more responsive.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
