[ https://issues.apache.org/jira/browse/FLINK-11451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16757322#comment-16757322 ]
Timo Walther commented on FLINK-11451: -------------------------------------- Thank you [~xueyu]. 1. In your case, {{private[table]}} means a private constructor in Java. But sometimes you still need a way of extracting an internal field, so it really depends on common sense and the use case. 2. Yes, this is a good point. When we port {{ExternalCatalogTable}} we will also need it in {{flink-table-common}}. Let's put this descriptor there. The same package is also split in other modules, for example, the Kafka connector has also a descriptor in this package. > Move *QueryConfig and TableDescriptor to flink-table-api-java > ------------------------------------------------------------- > > Key: FLINK-11451 > URL: https://issues.apache.org/jira/browse/FLINK-11451 > Project: Flink > Issue Type: New Feature > Components: Table API & SQL > Reporter: Timo Walther > Assignee: xueyu > Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > A more detailed description can be found in > [FLIP-32|https://cwiki.apache.org/confluence/display/FLINK/FLIP-32%3A+Restructure+flink-table+for+future+contributions]. > Move QueryConfig, BatchQueryConfig, StreamQueryConfig, TableDescriptor in > flink-table-api-java. > Unblocks TableEnvironment interface task. -- This message was sent by Atlassian JIRA (v7.6.3#76005)