tzulitai commented on a change in pull request #7601: [FLINK-11164] Check for
sentinel values when creating new Kinesis ShardIterator
URL: https://github.com/apache/flink/pull/7601#discussion_r252221638
##########
File path:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/SentinelSequenceNumber.java
##########
@@ -54,4 +57,17 @@
public SequenceNumber get() {
return sentinel;
}
+
+ /**
+ * Returns a {@link List} of {@link SequenceNumber SequenceNumbers}
that are used as sentinel
+ * values.
+ */
+ public static List<SequenceNumber> getAllSentinelSequenceNumbers() {
+ List<SequenceNumber> result = new ArrayList<>(values().length);
Review comment:
Can we just have a static method `isSentinelSequenceNumber(SequenceNumber
num)` to avoid an array list creation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
