ggevay commented on issue #3511: [Flink-5734] code generation for normalizedkey 
sorter
URL: https://github.com/apache/flink/pull/3511#issuecomment-458913525
 
 
   Hi @twalthr ,
   
   This PR has a similar status as the serializer codegen PR, explained here:
   https://github.com/apache/flink/pull/2211#issuecomment-389240577
   
   In the last paragraph of that comment I mentioned that there will be an MSc 
student working on an alternative approach, which would subsume both PRs. In 
the meantime, @mukrram-bajwa wrote a nice MSc thesis on this alternative 
approach, but unfortunately it's far from a PR-ready state, and I'm not sure at 
the moment whether we will push it further, or how feasible is the approach for 
pushing it to production-readiness.
   
   Btw. I don't know the details about the Blink improvements. Maybe that 
subsumes both of these PRs and even the alternative approach that was pursued 
in the MSc thesis, but I don't know. Or it might win solely on the basis of 
being closer to production readiness.
   
   I suggest to just close both of these PRs for now, and then maybe later get 
back to these performance issues with a fresh mind.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to