eaglewatcherwb edited a comment on issue #7436: [FLINK-11071][core] add support 
for dynamic proxy classes resolution …
URL: https://github.com/apache/flink/pull/7436#issuecomment-458471640
 
 
   > Hi @eaglewatcherwb, I slightly improved the test. You can have a look 
here: 
[dawidwys@c6f67c1](https://github.com/dawidwys/flink/commit/c6f67c1a1197abc4faf6340a8e7ff3d09a8a6ba9)
   > 
   > Basically I changed it so that:
   > 
   > * both interface and the invocation handler comes from the user classloader
   > * I used the `InstationUtil#serialize/deserialize` methods, which are the 
user facing ones.
   > 
   > I will merge it like that, thank you for your contribution!
   
   It's my pleasure, and nice improvement over the test. PS, I left a minor 
comment on the code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to