TisonKun commented on a change in pull request #7303: [FLINK-10569] [tests] Get 
rid of Scheduler from valid tests
URL: https://github.com/apache/flink/pull/7303#discussion_r248781777
 
 

 ##########
 File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/VertexSlotSharingTest.java
 ##########
 @@ -90,12 +90,12 @@ public void testAssignSlotSharingGroup() {
                                new SerializedValue<>(new ExecutionConfig()),
                                AkkaUtils.getDefaultTimeout(),
                                new NoRestartStrategy(),
-                               new 
Scheduler(TestingUtils.defaultExecutionContext()));
+                               new TestingSlotProvider(ignored -> new 
CompletableFuture<>()));
                        eg.attachJobGraph(vertices);
                        
                        // verify that the vertices are all in the same slot 
sharing group
-                       SlotSharingGroup group1 = null;
-                       SlotSharingGroup group2 = null;
+                       SlotSharingGroup group1;
 
 Review comment:
   Revert while rebasing.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to