zhuzhurk commented on a change in pull request #7255: [FLINK-10945] Use 
InputDependencyConstraint to avoid resource dead…
URL: https://github.com/apache/flink/pull/7255#discussion_r248145662
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionVertex.java
 ##########
 @@ -689,7 +693,7 @@ void scheduleOrUpdateConsumers(ResultPartitionID 
partitionId) {
 
                if 
(partition.getIntermediateResult().getResultType().isPipelined()) {
                        // Schedule or update receivers of this partition
-                       partition.markSomePipelinedDataProduced();
+                       partition.markDataProduced();
 
 Review comment:
   Sure,  `partition.markDataProduced` is fine for BLOCKING result. I moved it 
out from the `if` clause.
   
   In my understanding, the `ExecutionVertex.scheduleOrUpdateConsumers` is for 
PIPELINED partition currently. Only PIPELINED partition will send the 
`scheduleOrUpdateConsumers` message and the method will throw exception if the 
partition is BLOCKING. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to