tillrohrmann commented on issue #7459: [FLINK-11300] Make MetricFetcher update interval configurable URL: https://github.com/apache/flink/pull/7459#issuecomment-453542393 Thanks for the review @zentol and @zjffdu. I've addressed all your comments: - Renamed `MetricFetcher` into `MetricFetcherImpl` to be able to extract the `MetricFetcher` interface - Pass in `MetricFetcher` instead of `MetricQueryServiceRetriever` into the `WebMonitorEndpoint` - Remove `RestHandlerConfiguration#metricFetcherUpdateInterval` - Moved `METRIC_FETCHER_UPDATE_INTERVAL` into `MetricOptions`
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
