FaxianZhao commented on a change in pull request #7344: [FLINK-4369] Optimize evict performance for the TriggerResult.FIRE_AND_PURGE URL: https://github.com/apache/flink/pull/7344#discussion_r247087864
########## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperator.java ########## @@ -333,7 +333,7 @@ public void onProcessingTime(InternalTimer<K, W> timer) throws Exception { } } - private void emitWindowContents(W window, Iterable<StreamRecord<IN>> contents, ListState<StreamRecord<IN>> windowState) throws Exception { + private void emitWindowContents(W window, Iterable<StreamRecord<IN>> contents, ListState<StreamRecord<IN>> windowState, boolean purge) throws Exception { Review comment: Accept. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services