zentol commented on a change in pull request #7340: [FLINK-11174] [prometheus] Flink Metrics Prometheus label values supp… URL: https://github.com/apache/flink/pull/7340#discussion_r247067028
########## File path: docs/monitoring/metrics.md ########## @@ -652,7 +652,6 @@ of your Flink distribution. Parameters: - `port` - (optional) the port the Prometheus exporter listens on, defaults to [9249](https://github.com/prometheus/prometheus/wiki/Default-port-allocations). In order to be able to run several instances of the reporter on one host (e.g. when one TaskManager is colocated with the JobManager) it is advisable to use a port range like `9250-9260`. -- `filterLabelValueCharacters` - (optional) Specifies whether to filter label value characters. It's default to true, so only \[a-zA-Z0-9:_\] are valid. If set to false, label values can contain any Unicode characters. Review comment: this shouldn't have been reverted ;) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
