zentol commented on a change in pull request #7459: [FLINK-11300] Make MetricFetcher update interval configurable URL: https://github.com/apache/flink/pull/7459#discussion_r247063941
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/RestHandlerConfiguration.java ########## @@ -78,10 +83,17 @@ public static RestHandlerConfiguration fromConfiguration(Configuration configura final String rootDir = "flink-web-ui"; final File webUiDir = new File(configuration.getString(WebOptions.TMP_DIR), rootDir); + final long metricFetcherUpdateInterval = configuration.getLong(WebOptions.METRIC_FETCHER_UPDATE_INTERVAL); Review comment: missing sanity checks for being > 0. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services