[GitHub] JaryZhen commented on a change in pull request #7466: [FLINK-11304] Fix typo in time attributes doc

[GitBox]

JaryZhen commented on a change in pull request #7466: [FLINK-11304] Fix typo in 
time attributes doc
URL: https://github.com/apache/flink/pull/7466#discussion_r247049482
 
 

 ##########
 File path: docs/dev/table/streaming/time_attributes.md
 ##########
 @@ -284,13 +284,19 @@ public class UserActionSource implements 
StreamTableSource<Row>, DefinedRowtimeA
        }
 
        @Override
-       public String getRowtimeAttribute() {
+       public List<RowtimeAttributeDescriptor> 
getRowtimeAttributeDescriptors() {
                // Mark the "UserActionTime" attribute as event-time attribute.
-               return "UserActionTime";
+               // here we create one attribute descriptor of "UserActionTime"
+               RowtimeAttributeDescriptor rowtimeAttrDescr = new 
RowtimeAttributeDescriptor(
+                   "UserActionTime",
 
 Review comment:
   Hi, I think it's correct now, here is the code view form my patch.
   
![image](https://user-images.githubusercontent.com/13216107/51024910-ae636180-15c5-11e9-8bc2-5a27f6f4d30d.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services