eaglewatcherwb commented on issue #7412: [FLINK-10866][Runtime] 1. Explicitly enable qs server and proxy. 2. QS URL: https://github.com/apache/flink/pull/7412#issuecomment-451853929 > > > @eaglewatcherwb Thanks for this PR! > > > Agree to the "query-server.enable" configuration, but I'm not sure that we should prevent all the failures which are caused by this, because the queryable state may be a main feature for some business. > > > I wonder that if we can enable this server by checking the registeredKvStates so that we can know if the uses are really using the feature. > > > > > > @buptljy Thanks for the comments. > > **checking the registeredKvStates** do you mean **registerQueryableState** in TaskExecutor ? > > The queryable state will be registered in KvStateRegistry when it is published, which enables you to know if users have queryable state, with kvStateRegistry in NetworkEnvironment. kvStateRegistry in NetworkEnvironment is always associated with JobId and the queryable state is registered when a task runs on TM, however, QS server is a service of TM, which is independent of job or task and a common service of TM, and is initialized before a task runs on TM. Thus, I think it may be improper to enable QS service by checking the registeredKvStates, and should by user explicit configuration.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
