tweise commented on a change in pull request #6968: [FLINK-4582] [kinesis]
Consuming data from DynamoDB streams to flink
URL: https://github.com/apache/flink/pull/6968#discussion_r243471372
##########
File path:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/ConsumerConfigConstants.java
##########
@@ -143,6 +128,13 @@ public SentinelSequenceNumber toSentinelSequenceNumber() {
/** The interval after which to consider a shard idle for purposes of
watermark generation. */
public static final String SHARD_IDLE_INTERVAL_MILLIS =
"flink.shard.idle.interval";
+ /**
+ * Boolean to indicate whether to compare/enforce shardId format based
on the one defined in
+ * DynamodbStreamsShardHandle.
+ */
+ public static final String DYNAMODB_STREAMS_SHARDID_FORMAT_CHECK =
Review comment:
This property isn't actually used? If so, please remove.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
