tweise commented on issue #7249: [FLINK-11048] Ability to programmatically execute streaming pipeline with savepoint restore URL: https://github.com/apache/flink/pull/7249#issuecomment-449078240 > Just to sum up my review. > > * Personally would prefer method `execute(String jobName, SavepointSettings savepointSettings`, but I am ok with the ctor as well > * Before merging this PR please annotate newly introduced methods/ctor with `@Internal` or at least `@PublicEvolving` > > After that I am +1 @dawidwys thanks for the review. I marked the new method `public static JobExecutionResult executeRemotely` as evolving. I would also prefer the execute method with the savepoint restore settings (the previous version of the PR had that actually). Unfortunately we had to discard that (in favor of the constructor) because it would require the savepoint restore parameter to be passed through a member variable to still be able to call `protected JobExecutionResult executeRemotely(StreamGraph streamGraph, List<URL> jarFiles)`, which we have to for backward compatibility..
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
