sunjincheng121 commented on a change in pull request #7315:
[FLINK-11179][tests] add wait time for every record for testCancelSor…
URL: https://github.com/apache/flink/pull/7315#discussion_r242356994
##########
File path:
flink-tests/src/test/java/org/apache/flink/test/cancelling/JoinCancelingITCase.java
##########
@@ -122,9 +122,11 @@ public void testCancelSortMatchWithHighparallelism()
throws Exception {
private static final class SimpleMatcher<IN> implements
JoinFunction<Tuple2<IN, IN>, Tuple2<IN, IN>, Tuple2<IN, IN>> {
private static final long serialVersionUID = 1L;
+ private static final int WAIT_TIME_PER_RECORD = 300; // 0.3 sec.
Review comment:
Hi Thanks for the review @hequn8128 !
If we using `DelayingMatcher ` then we do not need this test case anymore.
So I think both add the wait_time and make delayingMatcher are can not achieve
the purpose of testing。 Because wait_time and delayingMatcher only test the
join phase，we want test the sore-merge phase. So we should make sore-merge
phase take more time to achieve the purpose of testing. I got a better
approach，and will update the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
