[jira] [Commented] (FLINK-2536) Add a retry for SocketClientSink

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/FLINK-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14710815#comment-14710815
 ] 

ASF GitHub Bot commented on FLINK-2536:
---------------------------------------

Github user HuangWHWHW commented on the pull request:

    https://github.com/apache/flink/pull/1030#issuecomment-134513103
  
    @tillrohrmann
    Hi, I take a new fix.
    But this:
    
![image](https://cloud.githubusercontent.com/assets/13193847/9461264/eccf96cc-4b3f-11e5-8d08-19ecd83eff7c.png)
    I have no good idea to care both the sink need to retry and should not 
finished retry when I reopen the socket server.
    So, I change the test "testSocketSinkRetryAccess” from retry ten times to 
retry forever since this will never finished retry until the method 
closeConnection() is called or the reconnect is success.


> Add a retry for SocketClientSink
> --------------------------------
>
>                 Key: FLINK-2536
>                 URL: https://issues.apache.org/jira/browse/FLINK-2536
>             Project: Flink
>          Issue Type: Improvement
>          Components: Streaming
>    Affects Versions: 0.10
>            Reporter: Huang Wei
>             Fix For: 0.10
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> I found the SocketClientSink doesn`t use a re-connect when disconnect from 
> the socket server or get exception.
> I`d like to add a re-connect like socket source for socket sink.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)