dikei commented on a change in pull request #7078: [FLINK-10848][YARN] properly
remove YARN ContainerRequest upon container allocation success
URL: https://github.com/apache/flink/pull/7078#discussion_r241702906
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnFlinkResourceManager.java
##########
@@ -438,6 +438,8 @@ private void containersAllocated(List<Container>
containers) {
numPendingContainerRequests = Math.max(0,
numPendingContainerRequests - 1);
LOG.info("Received new container: {} - Remaining
pending container requests: {}",
container.getId(), numPendingContainerRequests);
+ resourceManagerClient.removeContainerRequest(new
AMRMClient.ContainerRequest(
Review comment:
Is this safe to create a new container request object ? Maybe we should call
`getMatchingRequests` and remove one of the returned results.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
