dianfu commented on a change in pull request #7253: [FLINK-11074]
[table][tests] Enable harness tests with RocksdbStateBackend and add harness
tests for CollectAggFunction
URL: https://github.com/apache/flink/pull/7253#discussion_r241626349
##########
File path:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/harness/HarnessTestBase.scala
##########
@@ -491,13 +491,83 @@ class HarnessTestBase {
distinctCountFuncName,
distinctCountAggCode)
+ def createHarnessTester[KEY, IN, OUT](
+ dataStream: DataStream[_],
+ prefixOperatorName: String)
Review comment:
createHarnessTester will be used not only in agg related tests but also in
other harness tests, such as stream join tests, temporal join tests, sort
tests, etc. So field aggFieldAlias seems a little wired from my point of view.
What about adding it when we really need it? At that time we may have a better
idea on how such a field will look like. Thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
