[
https://issues.apache.org/jira/browse/FLINK-9461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16711081#comment-16711081
]
vinoyang commented on FLINK-9461:
---------------------------------
[~twalthr] Some interfaces, such as StreamTableSinkFactory, are used by
multiple connectors. So while migrating, I probably won't delete them, but
instead create a copy of the Java implementation in table-common. I have done
[most of the
work|https://github.com/yanghua/flink/commit/03e69684d7f584618fb5db04be13c63a403d6d12]
right now, but the transitive dependencies of some interfaces make it
impossible to compile successfully and need to rethink.
In addition, I suggest that we create an umbrella issue for migrating all
connectors and then use the current issue as a sub task.
The migration of connectors and the transformation of interfaces should be
centralized.
What do you think?
> Disentangle flink-connector-kafka from flink-table and flink-json
> -----------------------------------------------------------------
>
> Key: FLINK-9461
> URL: https://issues.apache.org/jira/browse/FLINK-9461
> Project: Flink
> Issue Type: Sub-task
> Components: Build System
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: vinoyang
> Priority: Major
> Fix For: 1.8.0
>
>
> Currently, the {{flink-connector-kafka}} module has a dependency on
> {{flink-table}} and {{flink-json}}. The reason seems to be that the module
> contains the {{KafkaJsonTableSource}} and {{KafkaJsonTableSink}}. Even though
> the {{flink-table}} and {{flink-json}} dependency are marked as optional, the
> {{flink-connector-kafka}} will still contain the table sources and sinks. I
> think this is not a clean design.
> I would propose to move the table sources and sinks into a dedicated module
> which depends on {{flink-connector-kafka}}. That way we would better separate
> dependencies and could remove {{flink-table}} and {{flink-json}} from
> {{flink-connector-kafka}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
