hequn8128 commented on issue #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#issuecomment-444533622 @pnowojski Hi, thanks a lot for your review and great suggestions. I have updated the pr according to your suggestions. Changes mainly include: - Add `UnresolvedKeyFieldReference` - Rename `LastRow` to `UpsertToRetraction` - Generate `UpsertToRetraction` from `RelTimeIndicatorConverter` to `EnumerableToLogicalTableScan` - Add `RemoveDataStreamUpsertToRetractionRule` to `UpsertToRetraction` relnode if it is a no-op node. Would be great if you can take a look when you are free. Thanks a lot. Best, Hequn
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
