[
https://issues.apache.org/jira/browse/FLINK-6756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704603#comment-16704603
]
ASF GitHub Bot commented on FLINK-6756:
---------------------------------------
dawidwys commented on a change in pull request #7168: [FLINK-6756][DataStream
API] Provide Rich AsyncFunction to Scala API …
URL: https://github.com/apache/flink/pull/7168#discussion_r237784333
##########
File path:
flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/async/util/ScalaRichAsyncFunctionWrapper.scala
##########
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.api.scala.async.util
Review comment:
Move one level up. See no reason to introduce separate package for a single
class. We have the `JavaResultFutureWrapper` there already, which is quite
similar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Provide RichAsyncFunction to Scala API suite
> --------------------------------------------
>
> Key: FLINK-6756
> URL: https://issues.apache.org/jira/browse/FLINK-6756
> Project: Flink
> Issue Type: Improvement
> Components: DataStream API
> Reporter: Andrea Spina
> Assignee: Andrea Spina
> Priority: Major
> Labels: pull-request-available
>
> I can't find any tracking info about the chance to have RichAsyncFunction in
> the Scala API suite. I think it'd be nice to have this function in order to
> access open/close methods and the RuntimeContext.
> I was able to retrieve
> http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/There-is-no-Open-and-Close-method-in-Async-I-O-API-of-Scala-td11591.html#a11593
> only, so my question is if there are some blocking issues avoiding this
> feature. [~till.rohrmann]
> If it's possible and nobody already have done it, I can assign the issue to
> myself in order to implement it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
