[
https://issues.apache.org/jira/browse/FLINK-7599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16703169#comment-16703169
]
ASF GitHub Bot commented on FLINK-7599:
---------------------------------------
twalthr commented on a change in pull request #7177: [FLINK-7599] [table]
Support for aggregates in MATCH_RECOGNIZE
URL: https://github.com/apache/flink/pull/7177#discussion_r237460915
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/MatchCodeGenerator.scala
##########
@@ -72,12 +78,28 @@ class MatchCodeGenerator(
private var offset: Int = 0
private var first : Boolean = false
+ /**
+ * Flags that tells if we generate expressions inside an aggregate. It
tells how to access input
+ * row.
+ */
+ private var innerAggExpr: Boolean = false
+
+ /**
+ * Name of term in function used to transform input row into aggregate
input row.
+ */
+ private val inputAggRowTerm = newName("inAgg")
Review comment:
All final variable term in this class must not be created with `newName`
they can be constant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Support aggregation functions in the define and measures clause of
> MatchRecognize
> ---------------------------------------------------------------------------------
>
> Key: FLINK-7599
> URL: https://issues.apache.org/jira/browse/FLINK-7599
> Project: Flink
> Issue Type: Sub-task
> Components: CEP, Table API & SQL
> Reporter: Dian Fu
> Assignee: Dawid Wysakowicz
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.8.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
