twalthr commented on a change in pull request #7177: [FLINK-7599] [table] Support for aggregates in MATCH_RECOGNIZE URL: https://github.com/apache/flink/pull/7177#discussion_r237471737
########## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/MatchCodeGenerator.scala ########## @@ -304,10 +349,14 @@ class MatchCodeGenerator( } override def visitPatternFieldRef(fieldRef: RexPatternFieldRef): GeneratedExpression = { - if (fieldRef.getAlpha.equals("*") && currentPattern.isDefined && offset == 0 && !first) { - generateInputAccess(input, input1Term, fieldRef.getIndex) + if (innerAggExpr) { Review comment: Call this variable `isWithinAggExprState` or similar? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services