[
https://issues.apache.org/jira/browse/FLINK-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702620#comment-16702620
]
ASF GitHub Bot commented on FLINK-8577:
---------------------------------------
hequn8128 commented on a change in pull request #6787: [FLINK-8577][table]
Implement proctime DataStream to Table upsert conversion
URL: https://github.com/apache/flink/pull/6787#discussion_r237329703
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/DataStreamScanRule.scala
##########
@@ -36,25 +36,32 @@ class DataStreamScanRule
override def matches(call: RelOptRuleCall): Boolean = {
val scan: FlinkLogicalNativeTableScan =
call.rel(0).asInstanceOf[FlinkLogicalNativeTableScan]
- val dataSetTable = scan.getTable.unwrap(classOf[DataStreamTable[Any]])
- dataSetTable match {
- case _: DataStreamTable[Any] =>
- true
- case _ =>
- false
- }
+ val appendTable = scan.getTable.unwrap(classOf[AppendStreamTable[Any]])
+ val upsertTable = scan.getTable.unwrap(classOf[UpsertStreamTable[Any]])
+
+ appendTable != null || upsertTable != null
Review comment:
I think you are right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Implement proctime DataStream to Table upsert conversion.
> ---------------------------------------------------------
>
> Key: FLINK-8577
> URL: https://issues.apache.org/jira/browse/FLINK-8577
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Hequn Cheng
> Assignee: Hequn Cheng
> Priority: Major
> Labels: pull-request-available
>
> Api will looks like:
> {code:java}
> DataStream[(String, Long, Int)] input = ???
> // upsert with keyTable
> table = tEnv.upsertFromStream(input, 'a, 'b, 'c.key)
> // upsert without key -> single row tableTable
> table = tEnv.upsertFromStream(input, 'a, 'b, 'c){code}
> A simple design
> [doc|https://docs.google.com/document/d/1yMEi9xkm3pNYNmmZykbLzqtKjFVezaWe0y7Xqd0c1zE/edit?usp=sharing]
> about this subtask.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
