[
https://issues.apache.org/jira/browse/FLINK-10712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16699077#comment-16699077
]
ASF GitHub Bot commented on FLINK-10712:
----------------------------------------
StefanRRichter commented on a change in pull request #7009: [FLINK-10712]
Support to restore state when using RestartPipelinedRegionStrategy
URL: https://github.com/apache/flink/pull/7009#discussion_r236283201
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperation.java
##########
@@ -201,31 +261,33 @@ private void assignTaskStateToExecutionJobVertices(
for (int subTaskIndex = 0; subTaskIndex < newParallelism;
subTaskIndex++) {
- Execution currentExecutionAttempt =
executionJobVertex.getTaskVertices()[subTaskIndex]
- .getCurrentExecutionAttempt();
+ if (subTaskIndices.contains(subTaskIndex)) {
Review comment:
instead of `for i in (0 .. newParallelism) -> `contains(i)`, why not supply
an `Iterable<Integer> subtaskIDs` instead and then `for (int subtask :
subtaskIDs)`? The old codepath would just pass in an iterable from 0 to new
parallelism.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> RestartPipelinedRegionStrategy does not restore state
> -----------------------------------------------------
>
> Key: FLINK-10712
> URL: https://issues.apache.org/jira/browse/FLINK-10712
> Project: Flink
> Issue Type: Bug
> Components: Distributed Coordination
> Affects Versions: 1.3.3, 1.4.2, 1.5.5, 1.6.2, 1.7.0
> Reporter: Stefan Richter
> Assignee: Yun Tang
> Priority: Critical
> Labels: pull-request-available
> Fix For: 1.8.0
>
>
> RestartPipelinedRegionStrategy does not perform any state restore. This is
> big problem because all restored regions will be restarted with empty state.
> We need to take checkpoints into account when restoring.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
