hequn8128 commented on a change in pull request #6787: [FLINK-8577][table]
Implement proctime DataStream to Table upsert conversion
URL: https://github.com/apache/flink/pull/6787#discussion_r236267295
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/ExpressionParser.scala
##########
@@ -535,6 +536,13 @@ object ExpressionParser extends JavaTokenParsers with
PackratParsers {
case f ~ _ ~ _ => RowtimeAttribute(f)
}
+ // key
+
+ lazy val key: PackratParser[Expression] =
+ (aliasMapping | "(" ~> aliasMapping <~ ")" | fieldReference) ~ "." ~ KEY
^^ {
Review comment:
Do you mean deduplicate the code? I think we can add another `Expression`,
e.g., `lazy val aliasOrFieldReference = aliasMapping | "(" ~> aliasMapping <~
")" | fieldReference`, and reuse it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
