[
https://issues.apache.org/jira/browse/FLINK-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14706936#comment-14706936
]
ASF GitHub Bot commented on FLINK-2386:
---------------------------------------
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1039#issuecomment-133478852
Damn. You are right. I'll add the full type parameters again for the 0.9.1
backport (once this one is merged).
> Should we even differentiate between them, or only port the
PersistentKafkaSource to extend the FlinkKafkaConsumer
That's a good question. I though that having the two user-facing classes
would allow us to "silently" change the implementation for the different Kafka
versions if needed (for example when the new consumer API is out, and we know
its fully backwards compatible).
But I guess this is a matter of taste. I can change the name to
FlinkKafkaConsumer (without the version suffix) if you want.
Do you think having two `PersistentKafkaSource` in different packages is a
good idea?
I don't know whether Sink / Source or Producer / Consumer are better pairs
of names.
> Implement Kafka connector using the new Kafka Consumer API
> ----------------------------------------------------------
>
> Key: FLINK-2386
> URL: https://issues.apache.org/jira/browse/FLINK-2386
> Project: Flink
> Issue Type: Improvement
> Components: Kafka Connector
> Reporter: Robert Metzger
> Assignee: Robert Metzger
>
> Once Kafka has released its new consumer API, we should provide a connector
> for that version.
> The release will probably be called 0.9 or 0.8.3.
> The connector will be mostly compatible with Kafka 0.8.2.x, except for
> committing offsets to the broker (the new connector expects a coordinator to
> be available on Kafka). To work around that, we can provide a configuration
> option to commit offsets to zookeeper (managed by flink code).
> For 0.9/0.8.3 it will be fully compatible.
> It will not be compatible with 0.8.1 because of mismatching Kafka messages.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
