[ https://issues.apache.org/jira/browse/FLINK-10918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697807#comment-16697807 ]
ASF GitHub Bot commented on FLINK-10918: ---------------------------------------- imamitsehgal commented on a change in pull request #7153: FLINK-10918 Fix the checkpoint dir creation error on Window for keyed rocksdb state URL: https://github.com/apache/flink/pull/7153#discussion_r236042030 ########## File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java ########## @@ -557,6 +557,16 @@ private void createDB() throws IOException { this.defaultColumnFamily = columnFamilyHandles.get(0); } + private static class Utils { Review comment: valid point, I initially thought to create utility class, then decided to keep it local. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > incremental Keyed state with RocksDB throws cannot create directory error in > windows > ------------------------------------------------------------------------------------ > > Key: FLINK-10918 > URL: https://issues.apache.org/jira/browse/FLINK-10918 > Project: Flink > Issue Type: Bug > Components: Queryable State, State Backends, Checkpointing > Affects Versions: 1.6.2 > Environment: windows > {code:java} > val env = StreamExecutionEnvironment.getExecutionEnvironment > val rocksdb = new RocksDBStateBackend("file:\\C:\\rocksdb\\checkpoint",true) > rocksdb.setDbStoragePath("file:\\C:\\rocksdb\\storage") > env.setStateBackend(rocksdb) > env.enableCheckpointing(10) > {code} > > Reporter: Amit > Priority: Major > Labels: pull-request-available > Attachments: > 0001-FLINK-10918-Fix-for-checkpoint-creation-on-windows-1.patch > > > Facing error while enabling keyed state with RocksDBBackend with > checkpointing to a local windows directory > > {code:java} > Caused by: org.rocksdb.RocksDBException: Failed to create dir: > /c:/tmp/data/job_dbe01128760d4d5cb90809cd94c2a936_op_StreamMap_b5c8d46f3e7b141acf271f12622e752b__3_8__uuid_45c1f62b-a198-44f5-add5-7683079b03f8/chk-1.tmp: > Invalid argument > at org.rocksdb.Checkpoint.createCheckpoint(Native Method) > at org.rocksdb.Checkpoint.createCheckpoint(Checkpoint.java:51) > at > org.apache.flink.contrib.streaming.state.RocksDBKeyedStateBackend$RocksDBIncrementalSnapshotOperation.takeSnapshot(RocksDBKeyedStateBackend.java:2549) > at > org.apache.flink.contrib.streaming.state.RocksDBKeyedStateBackend$IncrementalSnapshotStrategy.performSnapshot(RocksDBKeyedStateBackend.java:2008) > at > org.apache.flink.contrib.streaming.state.RocksDBKeyedStateBackend.snapshot(RocksDBKeyedStateBackend.java:498) > at > org.apache.flink.streaming.api.operators.AbstractStreamOperator.snapshotState(AbstractStreamOperator.java:406) > ... 13 more > {code} > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)