StefanRRichter commented on a change in pull request #7153: FLINK-10918 Fix the
checkpoint dir creation error on Window for keyed rocksdb state
URL: https://github.com/apache/flink/pull/7153#discussion_r235996032
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
##########
@@ -2546,7 +2557,9 @@ void takeSnapshot() throws Exception {
// create hard links of living files in the snapshot
path
try (Checkpoint checkpoint =
Checkpoint.create(stateBackend.db)) {
-
checkpoint.createCheckpoint(localBackupDirectory.getDirectory().getPath());
+ LOG.info("Checkpoint path is {}.",
localBackupDirectory.getDirectory().getPath());
+ String path =
Utils.getPathAsString(localBackupDirectory.getDirectory());
Review comment:
Why not prepare this string just once in the evry beginning and use it for
the log message as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
