[ 
https://issues.apache.org/jira/browse/FLINK-9461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696589#comment-16696589
 ] 

Timo Walther commented on FLINK-9461:
-------------------------------------

[~yanghua] The main work on this issue has already been started. 
\{{flink-json}} is only used by deprecated code and can be removed once we drop 
format specific sources and sinks. I think we can remove `KafkaJsonTableSink` 
and `KafkaAvroTableSink` in the next release. Feel free to open a PR for this. 
I had a private discussion with [~aljoscha] and [~StephanEwen] about how we 
want to deal with \{{flink-table}} dependencies in connectors and formats. We 
decided against dedicated \{{flink-table-connectors}} and 
\{{flink-table-formats}} modules. Instead we started introducing a lightweight 
\{{flink-table-common}} module that currently only formats use but connectors 
can use this as well soon. See also the [discussion 
here|https://docs.google.com/document/d/1PPo6goW7tOwxmpFuvLSjFnx7BF8IVz0w3dcmPPyqvoY/edit#].

> Disentangle flink-connector-kafka from flink-table and flink-json
> -----------------------------------------------------------------
>
>                 Key: FLINK-9461
>                 URL: https://issues.apache.org/jira/browse/FLINK-9461
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Build System
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: vinoyang
>            Priority: Major
>             Fix For: 1.8.0
>
>
> Currently, the {{flink-connector-kafka}} module has a dependency on 
> {{flink-table}} and {{flink-json}}. The reason seems to be that the module 
> contains the {{KafkaJsonTableSource}} and {{KafkaJsonTableSink}}. Even though 
> the {{flink-table}} and {{flink-json}} dependency are marked as optional, the 
> {{flink-connector-kafka}} will still contain the table sources and sinks. I 
> think this is not a clean design.
> I would propose to move the table sources and sinks into a dedicated module 
> which depends on {{flink-connector-kafka}}. That way we would better separate 
> dependencies and could remove {{flink-table}} and {{flink-json}} from 
> {{flink-connector-kafka}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to