[
https://issues.apache.org/jira/browse/FLINK-10009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16694751#comment-16694751
]
ASF GitHub Bot commented on FLINK-10009:
----------------------------------------
XuQianJin-Stars opened a new pull request #7155: [FLINK-10009] Fix the casting
problem for function TIMESTAMPADD in Table
URL: https://github.com/apache/flink/pull/7155
## What is the purpose of the change
*Fix the casting problem for function TIMESTAMPADD in Table*
## Brief change log
- *In judging `ScalarOperators` `generateTemporalPlusMinus` function to add
the following the `date` conversion `timestamp` of logic, are as follows:*
```scala
case (SqlTimeTypeInfo.DATE, TimeIntervalTypeInfo.INTERVAL_MILLIS) =>
resultType match {
case SqlTimeTypeInfo.DATE =>
generateOperatorIfNotNull(nullCheck, SqlTimeTypeInfo.DATE, left,
right) {
(l, r) => s"$l $op ((int) ($r / ${MILLIS_PER_DAY}L))"
}
case SqlTimeTypeInfo.TIMESTAMP =>
generateOperatorIfNotNull(nullCheck, SqlTimeTypeInfo.TIMESTAMP,
left, right) {
(l, r) => s"$l * ${MILLIS_PER_DAY}L $op $r"
}
}
```
## Verifying this change
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe
tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *TIMESTAMPADD with DATE returns a TIMESTAMP value for sub-day intervals
`ScalarFunctionsTest`*
- *Round to the last day of previous month for `ScalarFunctionsTest`*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no /
don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs /
not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix the casting problem for function TIMESTAMPADD in Table
> ----------------------------------------------------------
>
> Key: FLINK-10009
> URL: https://issues.apache.org/jira/browse/FLINK-10009
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
> Reporter: Xingcan Cui
> Assignee: Ruidong Li
> Priority: Major
> Labels: pull-request-available
>
> There seems to be a bug in {{TIMESTAMPADD}} function. For example,
> {{TIMESTAMPADD(MINUTE, 1, DATE '2016-06-15')}} throws a
> {{ClassCastException}} ( java.lang.Integer cannot be cast to java.lang.Long).
> Actually, it tries to cast an integer date to a long timestamp in
> RexBuilder.java:1524 - {{return TimestampString.fromMillisSinceEpoch((Long)
> o)}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
