[
https://issues.apache.org/jira/browse/FLINK-5697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16693734#comment-16693734
]
ASF GitHub Bot commented on FLINK-5697:
---------------------------------------
tweise commented on a change in pull request #6980: [FLINK-5697] [kinesis] Add
periodic per-shard watermark support
URL: https://github.com/apache/flink/pull/6980#discussion_r235149642
##########
File path:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
##########
@@ -182,6 +189,28 @@
private volatile boolean running = true;
+ private final AssignerWithPeriodicWatermarks<T>
periodicWatermarkAssigner;
+
+ /**
+ * The watermark related state for each shard consumer. Entries in this
map will be created when shards
+ * are discovered. After recovery, this shard map will be recreated,
possibly with different shard index keys,
+ * since those are transient and not part of checkpointed state.
+ */
+ private ConcurrentHashMap<Integer, ShardWatermarkState> shardWatermarks
= new ConcurrentHashMap<>();
Review comment:
The mapping can change after recovery. It is not necessary to checkpoint
this though because the watermarks are derived information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add per-shard watermarks for FlinkKinesisConsumer
> -------------------------------------------------
>
> Key: FLINK-5697
> URL: https://issues.apache.org/jira/browse/FLINK-5697
> Project: Flink
> Issue Type: New Feature
> Components: Kinesis Connector, Streaming Connectors
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Thomas Weise
> Priority: Major
> Labels: pull-request-available
>
> It would be nice to let the Kinesis consumer be on-par in functionality with
> the Kafka consumer, since they share very similar abstractions. Per-partition
> / shard watermarks is something we can add also to the Kinesis consumer.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
