[
https://issues.apache.org/jira/browse/FLINK-10843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685417#comment-16685417
]
ASF GitHub Bot commented on FLINK-10843:
----------------------------------------
pnowojski commented on a change in pull request #7087: [FLINK-10843]
[connectors] Make Kafka table factory versioning more flexible
URL: https://github.com/apache/flink/pull/7087#discussion_r233101708
##########
File path: docs/dev/table/connect.md
##########
@@ -583,7 +586,9 @@ connector:
**Consistency guarantees:** By default, a Kafka sink ingests data with
at-least-once guarantees into a Kafka topic if the query is executed with
[checkpointing enabled]({{ site.baseurl
}}/dev/stream/state/checkpointing.html#enabling-and-configuring-checkpointing).
-**Kafka 0.10+ Timestamps:** Since Kafka 0.10, Kafka messages have a timestamp
as metadata that specifies when the record was written into the Kafka topic.
These timestamps can be used for a [rowtime
attribute](connect.html#defining-the-schema) by selecting `timestamps:
from-source` in YAML and `timestampsFromSource()` in Java/Scala respectively.
+**Kafka 0.10+ Timestamps:** Since Kafka 0.10, Kafka messages have a timestamp
as metadata that specifies when the record was written into the Kafka topic.
These timestamps can be used for a [rowtime
attribute](connect.html#defining-the-schema) by selecting `timestamps:
from-source` in YAML and `timestampsFromSource()` in Java/Scala respectively.
+
+**Kafka 0.11+ Versioning:** If the Kafka connector definition should be
independent of a hard-coded Kafka version, use the connector version
`universal` as a wildcard for Flink's modern Kafka connector.
Review comment:
Do not use `modern` - at some point of time it will not be modern anymore.
`universal`? `for Flink's Kafka connector that is compatible with all Kafka
versions starting from 0.11`.?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Make Kafka version definition more flexible for new Kafka table factory
> -----------------------------------------------------------------------
>
> Key: FLINK-10843
> URL: https://issues.apache.org/jira/browse/FLINK-10843
> Project: Flink
> Issue Type: Bug
> Components: Kafka Connector, Table API & SQL
> Affects Versions: 1.7.0
> Reporter: Timo Walther
> Assignee: Timo Walther
> Priority: Major
> Labels: pull-request-available
>
> Currently, a user has to specify a specific version for a Kafka connector
> like:
> {code}
> connector:
> type: kafka
> version: "0.11" # required: valid connector versions are "0.8", "0.9",
> "0.10", and "0.11"
> topic: ... # required: topic name from which the table is read
> {code}
> However, the new Kafka connector aims to be universal, thus, at least for 1.x
> and 2.x versions which we should support those as parameters as well.
> Currently, {{2.0}} is the only accepted string for the factory.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
