[ 
https://issues.apache.org/jira/browse/FLINK-10624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684950#comment-16684950
 ] 

ASF GitHub Bot commented on FLINK-10624:
----------------------------------------

pnowojski commented on issue #6927: [FLINK-10624] Extend SQL client end-to-end 
to test new KafkaTableSink
URL: https://github.com/apache/flink/pull/6927#issuecomment-438201077
 
 
   In this case in the end we need 3 test files:
   1. Kafka tests in separate files (for 0.10 and 2.0).
   2. Main SQL client tests with `Executing SQL: Match recognize -> 
Elasticsearch`, as @twalthr said it can currently depend on the most recent 
Kafka. However ideally it shouldn't have a connector dependencies, or at least 
to have as few of them as possible (and connectors should be tested 
independently, but that is an independent issue)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Extend SQL client end-to-end to test new KafkaTableSink
> -------------------------------------------------------
>
>                 Key: FLINK-10624
>                 URL: https://issues.apache.org/jira/browse/FLINK-10624
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Kafka Connector, Table API & SQL, Tests
>    Affects Versions: 1.7.0
>            Reporter: Till Rohrmann
>            Assignee: vinoyang
>            Priority: Critical
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>
> With FLINK-9697, we added support for Kafka 2.0. We should also extend the 
> existing streaming client end-to-end test to also test the new 
> {{KafkaTableSink}} against Kafka 2.0.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to