[ 
https://issues.apache.org/jira/browse/FLINK-10626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681514#comment-16681514
 ] 

ASF GitHub Bot commented on FLINK-10626:
----------------------------------------

pnowojski commented on a change in pull request #7065: [FLINK-10626] [docs] 
[table] Add documentation for event-time temporal table joins
URL: https://github.com/apache/flink/pull/7065#discussion_r232267090
 
 

 ##########
 File path: docs/dev/table/streaming/joins.md
 ##########
 @@ -189,14 +189,26 @@ val result = orders
 </div>
 </div>
 
+**Note**: State retention defined in a [query 
configuration](query_configuration.html) is not yet considered for temporal 
joins. This means that the required state to compute the query result might 
grow infinitely depending on the number of distinct primary keys for the 
history table.
 
 Review comment:
   `s/not yet considered/not yet implemented/g`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add documentation for event-time temporal table joins
> -----------------------------------------------------
>
>                 Key: FLINK-10626
>                 URL: https://issues.apache.org/jira/browse/FLINK-10626
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Documentation, Table API &amp; SQL
>    Affects Versions: 1.7.0
>            Reporter: Till Rohrmann
>            Assignee: Timo Walther
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>
> The Flink documentation should be updated to cover the newly added 
> functionality.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to