[ 
https://issues.apache.org/jira/browse/FLINK-10835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Piotr Nowojski closed FLINK-10835.
----------------------------------
       Resolution: Fixed
    Fix Version/s: 1.8.0

merged commit 091cff3 into apache:master

> Remove duplicated Round-robin ChannelSelector implementation in 
> RecordWriterTest
> --------------------------------------------------------------------------------
>
>                 Key: FLINK-10835
>                 URL: https://issues.apache.org/jira/browse/FLINK-10835
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Network
>    Affects Versions: 1.8.0
>            Reporter: zhijiang
>            Assignee: zhijiang
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.8.0
>
>
> {{RoundRobinChannelSelector}} exists for default selector in {{RecordWriter}} 
> mainly for tests. Another similar {{RoundRobin}} implementation exists in 
> {{RecordWriterTest}}, only because the difference in starting channel index 
> for round-robin.
> We can adjust the test verify logic to keep the same behavior with 
> {{RoundRobinChannelSelector}}, and then remove the duplicated {{RoundRobin}}.
> It can make simple in following work 
> [FLINK-10622|https://issues.apache.org/jira/browse/FLINK-10662]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to